Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: xid would be duplicate in cluster mode #1456

Merged
merged 10 commits into from
Aug 14, 2019
Merged

bugfix: xid would be duplicate in cluster mode #1456

merged 10 commits into from
Aug 14, 2019

Conversation

Justice-love
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1455

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Justice-love Justice-love changed the title Node bug fix, XID would be duplicate in cluster mode Aug 14, 2019
@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #1456 into develop will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1456      +/-   ##
=============================================
+ Coverage      45.67%   45.68%   +<.01%     
  Complexity      1664     1664              
=============================================
  Files            345      345              
  Lines          12673    12675       +2     
  Branches        1593     1593              
=============================================
+ Hits            5789     5790       +1     
- Misses          6235     6236       +1     
  Partials         649      649
Impacted Files Coverage Δ Complexity Δ
server/src/main/java/io/seata/server/Server.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...src/main/java/io/seata/server/ParameterParser.java 55.17% <50%> (-0.39%) 6 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20882f0...187a798. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bug fix, XID would be duplicate in cluster mode bugfix: xid would be duplicate in cluster mode Aug 14, 2019
Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

@slievrly slievrly merged commit 417c3ee into apache:develop Aug 14, 2019
@Justice-love Justice-love deleted the node branch August 15, 2019 02:57
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XID would be duplicate in cluster mode
5 participants