-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: xid would be duplicate in cluster mode #1456
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1456 +/- ##
=============================================
+ Coverage 45.67% 45.68% +<.01%
Complexity 1664 1664
=============================================
Files 345 345
Lines 12673 12675 +2
Branches 1593 1593
=============================================
+ Hits 5789 5790 +1
- Misses 6235 6236 +1
Partials 649 649
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1455
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews