Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: data image compare log #1474

Merged
merged 4 commits into from
Aug 16, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Aug 16, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1463

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #1474 into develop will decrease coverage by 0.01%.
The diff coverage is 59.25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1474      +/-   ##
=============================================
- Coverage      45.77%   45.76%   -0.02%     
+ Complexity      1667     1666       -1     
=============================================
  Files            346      347       +1     
  Lines          12696    12711      +15     
  Branches        1593     1589       -4     
=============================================
+ Hits            5812     5817       +5     
- Misses          6236     6252      +16     
+ Partials         648      642       -6
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/io/seata/core/model/Result.java 0% <0%> (ø) 0 <0> (?)
.../java/io/seata/rm/datasource/DataCompareUtils.java 75.34% <86.95%> (+4.61%) 25 <2> (-2) ⬇️
...seata/rm/datasource/undo/AbstractUndoExecutor.java 83.16% <92.3%> (+0.01%) 21 <0> (+1) ⬆️
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a55ab...60c5ac9. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 9455ce8 into apache:develop Aug 16, 2019
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei deleted the bugfix/issues/1463-compare-log branch August 16, 2019 12:30
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when branch rollbacking, the data image compare log confused
6 participants