-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: data image compare log #1474
optimize: data image compare log #1474
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1474 +/- ##
=============================================
- Coverage 45.77% 45.76% -0.02%
+ Complexity 1667 1666 -1
=============================================
Files 346 347 +1
Lines 12696 12711 +15
Branches 1593 1589 -4
=============================================
+ Hits 5812 5817 +5
- Misses 6236 6252 +16
+ Partials 648 642 -6
Continue to review full report at Codecov.
|
rm-datasource/src/main/java/io/seata/rm/datasource/DataCompareUtils.java
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1463
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews