Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: provide mock module #1478

Merged
merged 20 commits into from
Sep 6, 2019
Merged

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Provide mock module for increase unit test coverage rate.

Ⅱ. Does this pull request fix one issue?

#1436

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #1478 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1478      +/-   ##
=============================================
+ Coverage      46.26%   46.42%   +0.16%     
  Complexity      1714     1714              
=============================================
  Files            350      350              
  Lines          12802    12828      +26     
  Branches        1578     1615      +37     
=============================================
+ Hits            5923     5956      +33     
- Misses          6219     6224       +5     
+ Partials         660      648      -12
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.61% <0%> (-0.61%) 67% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.95% <0%> (-0.21%) 3% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 9.09% <0%> (-0.11%) 4% <0%> (ø)
...tobuf/convertor/BranchCommitResponseConvertor.java 97.43% <0%> (+0.06%) 3% <0%> (ø) ⬇️
...in/java/io/seata/server/session/BranchSession.java 78.19% <0%> (+0.07%) 41% <0%> (ø) ⬇️
...buf/convertor/BranchRollbackResponseConvertor.java 97.36% <0%> (+0.07%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalCommitResponseConvertor.java 97.05% <0%> (+0.08%) 3% <0%> (ø) ⬇️
...buf/convertor/GlobalRollbackResponseConvertor.java 97.05% <0%> (+0.08%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalStatusResponseConvertor.java 97.05% <0%> (+0.08%) 3% <0%> (ø) ⬇️
...uf/convertor/GlobalLockQueryResponseConvertor.java 96.42% <0%> (+0.13%) 3% <0%> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91edf4...64b01fd. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit f9e3038 into apache:develop Sep 6, 2019
@l81893521 l81893521 deleted the new_mock_module branch September 17, 2019 11:24
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants