Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:support protobuf maven plugin #1489

Merged
merged 17 commits into from
Sep 12, 2019

Conversation

github-ygy
Copy link
Contributor

Ⅰ. Describe what this PR did

support protobuf maven plugin

Ⅱ. Does this pull request fix one issue?

support protobuf maven plugin to generate java code

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #1489 into develop will increase coverage by 11.65%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #1489       +/-   ##
==============================================
+ Coverage       35.1%   46.75%   +11.65%     
+ Complexity      2281     1730      -551     
==============================================
  Files            443      353       -90     
  Lines          23838    12941    -10897     
  Branches        3316     1618     -1698     
==============================================
- Hits            8369     6051     -2318     
+ Misses         14352     6238     -8114     
+ Partials        1117      652      -465
Impacted Files Coverage Δ Complexity Δ
...eata/rm/datasource/exec/LockConflictException.java 0% <0%> (-100%) 0% <0%> (-2%)
.../seata/rm/datasource/exec/LockRetryController.java 0% <0%> (-92.31%) 0% <0%> (-4%)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 9.37% <0%> (-62.5%) 2% <0%> (-4%)
...java/io/seata/rm/datasource/ConnectionContext.java 13.33% <0%> (-33.34%) 3% <0%> (-8%)
...a/rm/datasource/exec/LockWaitTimeoutException.java 0% <0%> (-33.34%) 0% <0%> (-1%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 8.51% <0%> (-14.38%) 4% <0%> (-6%)
...java/io/seata/rm/datasource/DataSourceManager.java 25.75% <0%> (-1.67%) 7% <0%> (ø)
...o/seata/rm/datasource/AbstractConnectionProxy.java 11.9% <0%> (-1.2%) 5% <0%> (-1%)
.../rm/datasource/exec/BaseTransactionalExecutor.java 17.39% <0%> (-0.87%) 6% <0%> (-1%)
.../main/java/io/seata/rm/datasource/AsyncWorker.java 15.58% <0%> (-0.86%) 4% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64759e7...0ba3ccf. Read the comment docs.

@slievrly
Copy link
Member

@github-ygy Why do you need to move the location of the proto file?

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leizhiyuan leizhiyuan added this to the 0.8.1 milestone Sep 7, 2019
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan self-requested a review September 7, 2019 16:33
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@ujjboy ujjboy added the status: waiting-for-feedback Waiting for feedback label Sep 9, 2019
Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants