-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:support protobuf maven plugin #1489
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1489 +/- ##
==============================================
+ Coverage 35.1% 46.75% +11.65%
+ Complexity 2281 1730 -551
==============================================
Files 443 353 -90
Lines 23838 12941 -10897
Branches 3316 1618 -1698
==============================================
- Hits 8369 6051 -2318
+ Misses 14352 6238 -8114
+ Partials 1117 652 -465
Continue to review full report at Codecov.
|
@github-ygy Why do you need to move the location of the proto file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
support protobuf maven plugin
Ⅱ. Does this pull request fix one issue?
support protobuf maven plugin to generate java code
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews