Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add table meta checker switch #1493

Merged
merged 11 commits into from
Aug 27, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Configuring table meta checker is done. But I m wondering is it necessary configuring the TABLE_META_CHECKER_INTERVAL as well?

Ⅱ. Does this pull request fix one issue?

#1483

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #1493 into develop will increase coverage by 0.14%.
The diff coverage is 80%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1493      +/-   ##
=============================================
+ Coverage      46.28%   46.42%   +0.14%     
- Complexity      1692     1693       +1     
=============================================
  Files            347      347              
  Lines          12691    12719      +28     
  Branches        1553     1591      +38     
=============================================
+ Hits            5874     5905      +31     
- Misses          6166     6173       +7     
+ Partials         651      641      -10
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/io/seata/rm/datasource/DataSourceProxy.java 71.87% <80%> (-1.46%) 8 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (-1.05%) 19% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.61% <0%> (-0.61%) 67% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.95% <0%> (-0.21%) 3% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 9.09% <0%> (-0.11%) 4% <0%> (ø)
...tobuf/convertor/BranchCommitResponseConvertor.java 97.43% <0%> (+0.06%) 3% <0%> (ø) ⬇️
...in/java/io/seata/server/session/BranchSession.java 78.19% <0%> (+0.07%) 41% <0%> (ø) ⬇️
...buf/convertor/BranchRollbackResponseConvertor.java 97.36% <0%> (+0.07%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalCommitResponseConvertor.java 97.05% <0%> (+0.08%) 3% <0%> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a44024...5210cf8. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this configuration item in nacos-config.txt

@l81893521
Copy link
Contributor Author

add this configuration item in nacos-config.txt

ok

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize: Configuring table meta checker optimize: add table meta checker switch Aug 27, 2019
@xingfudeshi xingfudeshi merged commit c71be4d into apache:develop Aug 27, 2019
@l81893521 l81893521 deleted the config_schedule_table_meta_cache branch September 17, 2019 11:21
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants