-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:support auto proxy of DataSource #1496
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1496 +/- ##
=============================================
- Coverage 46.45% 46.38% -0.08%
Complexity 1692 1692
=============================================
Files 347 348 +1
Lines 12711 12729 +18
Branches 1586 1588 +2
=============================================
- Hits 5905 5904 -1
- Misses 6167 6185 +18
- Partials 639 640 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall functional test passed, but when using the druid configuration init-method will report an error.
init-method="init" destroy-method="close"
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test function pass. Pls add this configuration item in nacos-config.txt
it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/DataSourceProxyHolder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
1.Simplify the Spring Integration,the only thing you need to do is define a bean of GlobalTransactionScanner.
2.Add a switch :spring.datasource.autoproxy,the default value is false
3.Unify file.conf.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done the integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews