Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:support auto proxy of DataSource #1496

Merged
merged 23 commits into from
Aug 28, 2019
Merged

feature:support auto proxy of DataSource #1496

merged 23 commits into from
Aug 28, 2019

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Aug 20, 2019

Ⅰ. Describe what this PR did

1.Simplify the Spring Integration,the only thing you need to do is define a bean of GlobalTransactionScanner.
2.Add a switch :spring.datasource.autoproxy,the default value is false
3.Unify file.conf.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done the integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #1496 into develop will decrease coverage by 0.07%.
The diff coverage is 9.52%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1496      +/-   ##
=============================================
- Coverage      46.45%   46.38%   -0.08%     
  Complexity      1692     1692              
=============================================
  Files            347      348       +1     
  Lines          12711    12729      +18     
  Branches        1586     1588       +2     
=============================================
- Hits            5905     5904       -1     
- Misses          6167     6185      +18     
- Partials         639      640       +1
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...g/annotation/datasource/DataSourceProxyHolder.java 0% <0%> (ø) 0 <0> (?)
...ta/spring/annotation/GlobalTransactionScanner.java 51.4% <15.38%> (-5.3%) 17 <1> (ø)
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fc980...f8e60a4. Read the comment docs.

@slievrly slievrly changed the title Support auto proxy of DataSource. feature:support auto proxy of DataSource Aug 20, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall functional test passed, but when using the druid configuration init-method will report an error.
init-method="init" destroy-method="close"

@xingfudeshi
Copy link
Member Author

The overall functional test passed, but when using the druid configuration init-method will report an error.
init-method="init" destroy-method="close"

done.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test function pass. Pls add this configuration item in nacos-config.txt

@xingfudeshi
Copy link
Member Author

test function pass. Pls add this configuration item in nacos-config.txt

it's done.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants