Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: EnhancedServiceLoader may be appears load class error #1518

Merged
merged 2 commits into from
Aug 23, 2019
Merged

bugfix: EnhancedServiceLoader may be appears load class error #1518

merged 2 commits into from
Aug 23, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Aug 22, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1517

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi
Copy link
Member

please change the title.

@jsbxyyx jsbxyyx changed the title fix #1517 fix EnhancedServiceLoader may be appears load class error Aug 23, 2019
@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #1518 into develop will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1518      +/-   ##
=============================================
+ Coverage      46.43%   46.44%   +<.01%     
  Complexity      1691     1691              
=============================================
  Files            347      347              
  Lines          12707    12709       +2     
  Branches        1588     1588              
=============================================
+ Hits            5901     5903       +2     
- Misses          6167     6168       +1     
+ Partials         639      638       -1
Impacted Files Coverage Δ Complexity Δ
.../io/seata/common/loader/EnhancedServiceLoader.java 62.29% <50%> (-0.21%) 24 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+0.34%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6ec9d...e113db3. Read the comment docs.

@jsbxyyx jsbxyyx changed the title fix EnhancedServiceLoader may be appears load class error bugfix: EnhancedServiceLoader may be appears load class error Aug 23, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit cd4fe5b into apache:develop Aug 23, 2019
@jsbxyyx jsbxyyx deleted the load branch August 23, 2019 03:54
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnhancedServiceLoader may be appears load class error
5 participants