Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ProtocolV1CodecTest testAll may be appears test not pass #1522

Merged
merged 2 commits into from
Aug 26, 2019
Merged

bugfix: ProtocolV1CodecTest testAll may be appears test not pass #1522

merged 2 commits into from
Aug 26, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Aug 23, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1521

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #1522 into develop will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1522      +/-   ##
=============================================
+ Coverage      46.27%   46.43%   +0.15%     
  Complexity      1691     1691              
=============================================
  Files            347      347              
  Lines          12713    12713              
  Branches        1561     1588      +27     
=============================================
+ Hits            5883     5903      +20     
+ Misses          6174     6172       -2     
+ Partials         656      638      -18
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.74%) 19% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterTMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 96.96% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 96.42% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchCommitRequestConvertor.java 100% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchReportRequestConvertor.java 96.29% <0%> (+3.7%) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterRMRequestConvertor.java 95.83% <0%> (+4.16%) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterTMRequestConvertor.java 100% <0%> (+4.54%) 3% <0%> (ø) ⬇️
...obuf/convertor/GlobalRollbackRequestConvertor.java 100% <0%> (+5.26%) 3% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0574dd5...342fcd7. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sometimes test over 10s will cause test failed.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 70b04d3 into apache:develop Aug 26, 2019
@jsbxyyx jsbxyyx deleted the test branch August 27, 2019 07:02
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProtocolV1CodecTest testAll may be appears test not pass
5 participants