Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: throw Exception when no index in the table #1530

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

git some tips when no index in the table cause NPE in TableMetaCache.java.

Ⅱ. Does this pull request fix one issue?

#1529

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #1530 into develop will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1530      +/-   ##
=============================================
+ Coverage      46.43%   46.44%   +0.01%     
- Complexity      1691     1692       +1     
=============================================
  Files            347      347              
  Lines          12713    12717       +4     
  Branches        1588     1590       +2     
=============================================
+ Hits            5903     5907       +4     
+ Misses          6172     6170       -2     
- Partials         638      640       +2
Impacted Files Coverage Δ Complexity Δ
...rm/datasource/sql/struct/TableMetaCacheOracle.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...seata/rm/datasource/sql/struct/TableMetaCache.java 53.65% <100%> (+1.8%) 14 <0> (+1) ⬆️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (-0.35%) 19% <0%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 64.56% <0%> (+0.78%) 24% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b04d3...3c84867. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit af9b417 into apache:develop Aug 27, 2019
@l81893521 l81893521 deleted the tips_when_no_index branch September 17, 2019 11:24
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants