Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of the logics of Multi-configuration Isolation #1533

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Refactor of the logics of Multi-configuration Isolation #1533

merged 5 commits into from
Aug 27, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

For the current logics of loading different configuration,it's a bit complicated to understand.So,i'm gonna improve it,and make it clearly.So,the new logics will be like:
At first,will try to read the name from JVM parameters(when use -Dxxx=xx),if reads nothing,will try to read the name from system environment,if reads nothing again,then will ues default configuration:file.conf,registry.conf.
For example,if we have a testing environment called "test",then these conf files should be in the following format:
file-test.conf registry-test.conf

Ⅱ. Does this pull request fix one issue?

fixes #1532

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #1533 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1533      +/-   ##
=============================================
- Coverage      46.44%   46.41%   -0.03%     
  Complexity      1692     1692              
=============================================
  Files            347      347              
  Lines          12719    12719              
  Branches        1591     1591              
=============================================
- Hits            5907     5904       -3     
- Misses          6171     6173       +2     
- Partials         641      642       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec2dfb...caaaf16. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 9481e47 into apache:develop Aug 27, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor of the logics of Multi-configuration Isolation
5 participants