-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of the logics of Multi-configuration Isolation #1533
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1533 +/- ##
=============================================
- Coverage 46.44% 46.41% -0.03%
Complexity 1692 1692
=============================================
Files 347 347
Lines 12719 12719
Branches 1591 1591
=============================================
- Hits 5907 5904 -3
- Misses 6171 6173 +2
- Partials 641 642 +1
Continue to review full report at Codecov.
|
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
For the current logics of loading different configuration,it's a bit complicated to understand.So,i'm gonna improve it,and make it clearly.So,the new logics will be like:
At first,will try to read the name from JVM parameters(when use -Dxxx=xx),if reads nothing,will try to read the name from system environment,if reads nothing again,then will ues default configuration:file.conf,registry.conf.
For example,if we have a testing environment called "test",then these conf files should be in the following format:
file-test.conf registry-test.conf
Ⅱ. Does this pull request fix one issue?
fixes #1532
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews