optimize: remove H2 and pgsql get primary index code and close resultSet #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1535 +/- ##
=============================================
+ Coverage 46.41% 46.46% +0.04%
- Complexity 1692 1693 +1
=============================================
Files 347 347
Lines 12719 12711 -8
Branches 1591 1586 -5
=============================================
+ Hits 5904 5906 +2
+ Misses 6173 6166 -7
+ Partials 642 639 -3
Continue to review full report at Codecov.
|
zjinlei
reviewed
Aug 27, 2019
| @@ -113,99 +112,97 @@ private static TableMeta fetchSchemeInDefaultWay(DataSource dataSource, String t | |||
|
|
|||
| private static TableMeta resultSetMetaToSchema(ResultSetMetaData rsmd, DatabaseMetaData dbmd, String tableName) | |||
| @@ -89,8 +89,7 @@ private static TableMeta fetchSchema(DataSource dataSource, String tableName) th | |||
| return fetchSchemeInDefaultWay(dataSource, tableName); | |||
| } | |||
|
|
|||
| private static TableMeta fetchSchemeInDefaultWay(DataSource dataSource, String tableName) | |||
| throws SQLException { | |||
| private static TableMeta fetchSchemeInDefaultWay(DataSource dataSource, String tableName) throws SQLException { | |||
| Connection conn = null; | |||
Signed-off-by: slievrly <slievrly@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: remove H2 and pgsql get primary index code and close resultSet
Ⅱ. Does this pull request fix one issue?
fix #1534
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews