Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: nacos-config.txt miss store.db.driver-class-name property #1537

Merged
merged 1 commit into from
Aug 27, 2019
Merged

bugfix: nacos-config.txt miss store.db.driver-class-name property #1537

merged 1 commit into from
Aug 27, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Aug 27, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1531

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@jsbxyyx jsbxyyx changed the title fix nacos config txt miss store.db.driver-class-name property bugfix: nacos config txt miss store.db.driver-class-name property Aug 27, 2019
@codecov-io
Copy link

codecov-io commented Aug 27, 2019 •
edited

Codecov Report

Merging #1537 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1537      +/-   ##
=============================================
+ Coverage      46.41%   46.44%   +0.03%     
  Complexity      1692     1692              
=============================================
  Files            347      347              
  Lines          12717    12717              
  Branches        1590     1590              
=============================================
+ Hits            5903     5907       +4     
+ Misses          6173     6171       -2     
+ Partials         641      639       -2
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9b417...989427e. Read the comment docs.

@slievrly slievrly changed the title bugfix: nacos config txt miss store.db.driver-class-name property bugfix: nacos-config.txt miss store.db.driver-class-name property Aug 27, 2019
slievrly
slievrly approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review August 27, 2019 07:53
xingfudeshi
xingfudeshi approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 0a44024 into apache:develop Aug 27, 2019
@jsbxyyx jsbxyyx deleted the nacos_config branch August 27, 2019 07:59
@xingfudeshi xingfudeshi mentioned this pull request Aug 29, 2019
Closed
@fescar-robot fescar-robot mentioned this pull request Aug 30, 2019
Closed
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.

store.db.driver-class-name is missing in nacos-config.txt
5 participants
@jsbxyyx @codecov-io @slievrly @xingfudeshi @wangliang181230