Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup #1541

Merged
merged 4 commits into from
Aug 28, 2019
Merged

code cleanup #1541

merged 4 commits into from
Aug 28, 2019

Conversation

cmonkey
Copy link
Contributor

@cmonkey cmonkey commented Aug 27, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #1541 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1541      +/-   ##
=============================================
- Coverage      46.45%   46.44%   -0.01%     
  Complexity      1692     1692              
=============================================
  Files            347      347              
  Lines          12719    12719              
  Branches        1591     1591              
=============================================
- Hits            5908     5907       -1     
  Misses          6171     6171              
- Partials         640      641       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e093e3a...c332bcb. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the pr title to describe the problem briefly and accurately

@xingfudeshi
Copy link
Member

Modify the pr title to describe the problem briefly and accurately

It should be code cleanup.

@cmonkey cmonkey changed the title rename REGISTRY_TYPE CONFIG_TYPE to ZookeeperConfiguration code cleanup Aug 27, 2019
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit 6f9667f into apache:develop Aug 28, 2019
@cmonkey cmonkey deleted the feature/change-zk-config branch October 11, 2019 09:27
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants