Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix typo #1544

Merged
merged 3 commits into from
Aug 28, 2019
Merged

optimize: fix typo #1544

merged 3 commits into from
Aug 28, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix typo

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 changed the title fix typo bugfix: fix typo Aug 27, 2019
@l81893521 l81893521 changed the title bugfix: fix typo optimize: fix typo Aug 27, 2019
@slievrly
Copy link
Member

Are there more other Chinese comments?

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #1544 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1544   +/-   ##
==========================================
  Coverage      34.51%   34.51%           
  Complexity      2209     2209           
==========================================
  Files            431      431           
  Lines          23560    23560           
  Branches        3291     3291           
==========================================
  Hits            8132     8132           
  Misses         14334    14334           
  Partials        1094     1094
Impacted Files Coverage Δ Complexity Δ
...n/java/io/seata/codec/protobuf/ProtobufHelper.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/io/seata/core/rpc/netty/NettyPoolKey.java 86.48% <ø> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9481e47...54f4f8f. Read the comment docs.

@l81893521
Copy link
Contributor Author

Are there more other Chinese comments?

yes. I will check it out later.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lovepoem lovepoem merged commit e093e3a into apache:develop Aug 28, 2019
@l81893521 l81893521 deleted the fix_typo branch September 17, 2019 11:25
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants