Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: TableRecords delete jackson annotation #1547

Merged
merged 3 commits into from
Aug 28, 2019
Merged

optimize: TableRecords delete jackson annotation #1547

merged 3 commits into from
Aug 28, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Aug 28, 2019

Ⅰ. Describe what this PR did

optimize TableRecords delete jackson annotation

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #1547 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1547      +/-   ##
============================================
+ Coverage      46.39%   46.4%   +<.01%     
  Complexity      1692    1692              
============================================
  Files            348     348              
  Lines          12722   12723       +1     
  Branches        1588    1588              
============================================
+ Hits            5903    5904       +1     
  Misses          6179    6179              
  Partials         640     640
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/sql/struct/TableRecords.java 73.77% <ø> (ø) 13 <0> (ø) ⬇️
...m/datasource/undo/parser/JacksonUndoLogParser.java 65.9% <100%> (+0.79%) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b71ca4...c8750bb. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit c5d2d2d into apache:develop Aug 28, 2019
@jsbxyyx jsbxyyx deleted the tablemeta branch August 29, 2019 01:11
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants