Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: throw NPE when the rpcMessage's body is null (#1556) #1558

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

cmonkey
Copy link
Contributor

@cmonkey cmonkey commented Aug 29, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1558 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1558   +/-   ##
=========================================
  Coverage       46.4%   46.4%           
  Complexity      1692    1692           
=========================================
  Files            348     348           
  Lines          12723   12723           
  Branches        1588    1588           
=========================================
  Hits            5904    5904           
  Misses          6179    6179           
  Partials         640     640
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/rpc/netty/RpcServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d2d2d...70272e3. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit dcb02c0 into apache:develop Aug 30, 2019
@cmonkey cmonkey deleted the feature/fix-1556 branch October 11, 2019 09:28
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants