-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: add UT for RegisterTMRequest #1575
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1575 +/- ##
=============================================
+ Coverage 46.35% 46.44% +0.08%
- Complexity 1690 1696 +6
=============================================
Files 348 348
Lines 12723 12723
Branches 1588 1588
=============================================
+ Hits 5898 5909 +11
+ Misses 6186 6175 -11
Partials 639 639
Continue to review full report at Codecov.
|
/** | ||
* Test to string. | ||
* @throws Exception the exception | ||
* @author linqiuping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
author move above class
/** | ||
* The type Register tm request test. | ||
* @author linqiuping | ||
* @since 2019/9/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove @since
,@since
is generally used after which version.
something wrong with your java doc, after class or method comment should have an empty line and no empty line after the end of the overall content.
*/ | ||
@Test | ||
public void testToString() throws Exception { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the test preferably contains all the public methods of this class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
add testcase for RegisterTMReques
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Why don't you add test cases (unit test/integration test)?
add a unit test case
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
The type Register tm request test. test tostring