Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize LockKeyConflictException and change register method #1580

Merged
merged 11 commits into from
Sep 9, 2019
Merged

optimize LockKeyConflictException and change register method #1580

merged 11 commits into from
Sep 9, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 3, 2019

Ⅰ. Describe what this PR did

  1. optimize LockKeyConflictException
  2. change method register(String lockKeys) to lockQuery(String lockKeys)

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #1580 into develop will decrease coverage by 0.04%.
The diff coverage is 6.25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1580      +/-   ##
=============================================
- Coverage      46.43%   46.39%   -0.05%     
+ Complexity      1718     1717       -1     
=============================================
  Files            350      350              
  Lines          12847    12855       +8     
  Branches        1618     1619       +1     
=============================================
- Hits            5966     5964       -2     
- Misses          6232     6242      +10     
  Partials         649      649
Impacted Files Coverage Δ Complexity Δ
...eata/rm/datasource/exec/LockConflictException.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/io/seata/rm/datasource/ConnectionProxy.java 8.51% <7.14%> (-0.59%) 4 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (-0.7%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce1c23...dc2e640. Read the comment docs.

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 1f9615f into apache:develop Sep 9, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants