bugfix: missing some length in GlobalSession and FileTransactionStoreManager #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1581 +/- ##
=============================================
+ Coverage 46.44% 46.46% +0.02%
- Complexity 1713 1714 +1
=============================================
Files 350 350
Lines 12829 12829
Branches 1616 1616
=============================================
+ Hits 5958 5961 +3
+ Misses 6224 6223 -1
+ Partials 647 645 -2
Continue to review full report at Codecov.
|
slievrly
reviewed
Sep 3, 2019
| @@ -416,9 +416,9 @@ private boolean writeDataFile(byte[] bs) { | |||
| } | |||
| ByteBuffer byteBuffer = null; | |||
|
|
|||
| if (bs.length > MAX_WRITE_BUFFER_SIZE) { | |||
| if (bs.length + INT_BYTE_SIZE > MAX_WRITE_BUFFER_SIZE) { | |||
There was a problem hiding this comment.
revert this file change，will duplicate with https://github.com/seata/seata/pull/1552/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix missing length in GlobalSession and FileTransactionStoreManager
Ⅱ. Does this pull request fix one issue?
No.
Ⅲ. Why don't you add test cases (unit test/integration test)?
No need.
Ⅳ. Describe how to verify it
By logical
Ⅴ. Special notes for reviews
BUG