optimize : optimize and standardize server log #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1593 +/- ##
=============================================
- Coverage 47.48% 47.24% -0.25%
Complexity 1764 1764
=============================================
Files 355 359 +4
Lines 12923 12997 +74
Branches 1610 1616 +6
=============================================
+ Hits 6137 6140 +3
- Misses 6121 6192 +71
Partials 665 665
Continue to review full report at Codecov.
|
jsbxyyx
reviewed
Sep 4, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManager.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Sep 4, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManagerOracle.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Sep 4, 2019
server/src/main/java/io/seata/server/session/AbstractSessionManager.java
Show resolved
Hide resolved
slievrly
reviewed
Sep 5, 2019
core/src/main/java/io/seata/core/exception/TmTransactionException.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Sep 8, 2019
server/src/main/java/io/seata/server/session/AbstractSessionManager.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Sep 10, 2019
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Sep 10, 2019
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
…_log # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManager.java # rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoLogManager.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
In some case could not know the transaction message clearly during transaction.
Ⅱ. Does this pull request fix one issue?
#1590
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews