Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: modify default namespace #1594

Merged
merged 4 commits into from
Sep 5, 2019
Merged

bugfix: modify default namespace #1594

merged 4 commits into from
Sep 5, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 4, 2019

Ⅰ. Describe what this PR did

bugfix: modify default namespace

Ⅱ. Does this pull request fix one issue?

fix #1592

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #1594 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1594      +/-   ##
=============================================
- Coverage       46.4%   46.35%   -0.05%     
+ Complexity      1691     1690       -1     
=============================================
  Files            348      348              
  Lines          12723    12723              
  Branches        1588     1588              
=============================================
- Hits            5904     5898       -6     
- Misses          6183     6186       +3     
- Partials         636      639       +3
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.4%) 19% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 50.45% <0%> (-0.92%) 26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aca068...10afd48. Read the comment docs.

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 9393ea6 into apache:develop Sep 5, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't get nacos config
6 participants