Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:FileConfiguration support system config file #1598

Merged
merged 4 commits into from
Sep 17, 2019
Merged

optimize:FileConfiguration support system config file #1598

merged 4 commits into from
Sep 17, 2019

Conversation

ldcsaa
Copy link
Contributor

@ldcsaa ldcsaa commented Sep 5, 2019

io.seata.config.FileConfiguration support system config file which with prefix 'file:'

#1577

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #1598 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1598      +/-   ##
=============================================
+ Coverage      47.18%   47.24%   +0.05%     
+ Complexity      1778     1764      -14     
=============================================
  Files            362      359       -3     
  Lines          13225    12999     -226     
  Branches        1641     1617      -24     
=============================================
- Hits            6240     6141      -99     
+ Misses          6308     6193     -115     
+ Partials         677      665      -12
Impacted Files Coverage Δ Complexity Δ
...m/datasource/undo/parser/JacksonUndoLogParser.java 65.9% <0%> (-2.04%) 4% <0%> (ø)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 71.87% <0%> (-1.66%) 6% <0%> (-1%)
...seata/rm/datasource/sql/struct/TableMetaCache.java 55.69% <0%> (-0.28%) 14% <0%> (ø)
...rm/datasource/sql/struct/TableMetaCacheOracle.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/rm/datasource/undo/parser/KryoUndoLogParser.java
.../datasource/undo/parser/KryoSerializerFactory.java
...eata/rm/datasource/undo/parser/KryoSerializer.java
.../rm/datasource/undo/mysql/MySQLUndoLogManager.java 3.05% <0%> (+0.09%) 2% <0%> (ø) ⬇️
...m/datasource/undo/oracle/OracleUndoLogManager.java 3.14% <0%> (+0.09%) 2% <0%> (ø) ⬇️
...a/io/seata/core/store/db/LockStoreDataBaseDAO.java 53.01% <0%> (+0.1%) 20% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f97497...2c0624e. Read the comment docs.

@xingfudeshi xingfudeshi self-requested a review September 12, 2019 08:34
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi changed the title io.seata.config.FileConfiguration support system config file optimize:FileConfiguration support system config file Sep 12, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 1617187 into apache:develop Sep 17, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants