Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix typo #1601

Merged
merged 4 commits into from
Sep 6, 2019
Merged

Conversation

andyqian
Copy link
Contributor

@andyqian andyqian commented Sep 6, 2019

Ⅰ. Describe what this PR did

fix typo

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #1601 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1601      +/-   ##
=============================================
- Coverage      46.44%   46.42%   -0.03%     
  Complexity      1713     1713              
=============================================
  Files            350      350              
  Lines          12827    12827              
  Branches        1615     1615              
=============================================
- Hits            5958     5955       -3     
- Misses          6222     6224       +2     
- Partials         647      648       +1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/common/util/DurationUtil.java 100% <100%> (ø) 16 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25da228...3a0d802. Read the comment docs.

@xingfudeshi xingfudeshi self-requested a review September 6, 2019 07:45
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 4aca480 into apache:develop Sep 6, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
@funky-eyes
Copy link
Contributor

由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants