Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue: upgrade fastjson version to 1.2.60 for security issue #1602

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Sep 6, 2019

Security issue: upgrade fastjson version to 1.2.60 (https://github.com/alibaba/fastjson/releases/tag/1.2.60) for security issue

Ⅱ. Does this pull request fix one issue?

yes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #1602 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1602      +/-   ##
=============================================
- Coverage      46.45%   46.42%   -0.04%     
  Complexity      1713     1713              
=============================================
  Files            350      350              
  Lines          12827    12827              
  Branches        1615     1615              
=============================================
- Hits            5959     5955       -4     
- Misses          6222     6224       +2     
- Partials         646      648       +2
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.4%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7696cd8...d5f77df. Read the comment docs.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 25da228 into apache:develop Sep 6, 2019
@lovepoem lovepoem deleted the upgrade_fastjson_version_to_1.2.60_for_security_issue branch September 6, 2019 06:26
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants