Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: solve NoSuchMethodError when the version of druid used < 1.1.3 #1607

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

ggndnn
Copy link
Contributor

@ggndnn ggndnn commented Sep 6, 2019

Ⅰ. Describe what this PR did

Use seata's StringUtils, instead of druid's.

Ⅱ. Does this pull request fix one issue?

fix #1606

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #1607 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1607      +/-   ##
=============================================
- Coverage      46.45%   46.44%   -0.01%     
  Complexity      1713     1713              
=============================================
  Files            350      350              
  Lines          12827    12827              
  Branches        1615     1615              
=============================================
- Hits            5959     5958       -1     
  Misses          6222     6222              
- Partials         646      647       +1
Impacted Files Coverage Δ Complexity Δ
...rm/datasource/sql/struct/TableMetaCacheOracle.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...seata/rm/datasource/sql/struct/TableMetaCache.java 55.69% <0%> (ø) 14 <1> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.03% <0%> (-0.35%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aca480...5114ab4. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit 0398ba2 into apache:develop Sep 6, 2019
@ggndnn ggndnn deleted the fix_issue_1606 branch September 13, 2019 10:33
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error java.lang.NoSuchMethodError occured if the druid used is a little old ( version < 1.1.3)
5 participants