feature: add seata.config.name configuration #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingfudeshi
reviewed
Sep 7, 2019
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Show resolved
Hide resolved
xingfudeshi
reviewed
Sep 7, 2019
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Show resolved
Hide resolved
xingfudeshi
reviewed
Sep 7, 2019
|
@xingfudeshi Thanks for your review. Please have a look whether my explanation appropriate. |
Codecov Report
@@ Coverage Diff @@
## develop #1617 +/- ##
=============================================
+ Coverage 47.37% 47.38% +<.01%
Complexity 1777 1777
=============================================
Files 362 362
Lines 13151 13151
Branches 1626 1626
=============================================
+ Hits 6230 6231 +1
Misses 6247 6247
+ Partials 674 673 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add seata.config.name configuration, registry.conf file name can be customized.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews