feature: support custom config and registry type #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1625 +/- ##
=============================================
+ Coverage 46.98% 47.15% +0.16%
- Complexity 1778 1784 +6
=============================================
Files 362 364 +2
Lines 13211 13259 +48
Branches 1603 1644 +41
=============================================
+ Hits 6207 6252 +45
- Misses 6314 6325 +11
+ Partials 690 682 -8
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
Sep 10, 2019
...ig/seata-config-custom/src/main/java/io/seata/config/custom/CustomConfigurationProvider.java
Outdated
Show resolved
Hide resolved
...ig/seata-config-custom/src/main/java/io/seata/config/custom/CustomConfigurationProvider.java
Outdated
Show resolved
Hide resolved
...iscovery-custom/src/main/java/io/seata/discovery/registry/custom/CustomRegistryProvider.java
Outdated
Show resolved
Hide resolved
ggndnn
force-pushed
the
feature_custom_config_type
branch
2 times, most recently
from
f92ad44
to
3c4e551
Compare
slievrly
reviewed
Sep 17, 2019
discovery/seata-discovery-core/src/main/java/io/seata/discovery/registry/RegistryFactory.java
Show resolved
Hide resolved
ggndnn
force-pushed
the
feature_custom_config_type
branch
from
6e0a57d
to
66263be
Compare
xingfudeshi
reviewed
Sep 19, 2019
config/seata-config-custom/src/test/java/io/seata/config/CustomConfigurationForTest.java
Outdated
Show resolved
Hide resolved
ggndnn
force-pushed
the
feature_custom_config_type
branch
from
d6737ca
to
87b43dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add custom config and registry type, which can be used to help users create their own configuration loading mechanism. Mainly used in client side.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews