-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: address list change events leak #1629
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1629 +/- ##
=============================================
- Coverage 47.19% 47.14% -0.06%
Complexity 1778 1778
=============================================
Files 362 362
Lines 13227 13237 +10
Branches 1640 1641 +1
=============================================
- Hits 6243 6240 -3
- Misses 6307 6319 +12
- Partials 677 678 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!LGTM.
@BeiKeJieDeLiuLangMao You need to re-push these commits. |
Because you've just associated your github account with email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Fix etcd registry service's server address list change events leak.
Ⅱ. Does this pull request fix one issue?
#1623
Ⅲ. Why don't you add test cases (unit test/integration test)?
No new api.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews