Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: address list change events leak #1629

Merged
merged 2 commits into from
Sep 18, 2019
Merged

bugfix: address list change events leak #1629

merged 2 commits into from
Sep 18, 2019

Conversation

BeiKeJieDeLiuLangMao
Copy link
Contributor

Ⅰ. Describe what this PR did

Fix etcd registry service's server address list change events leak.

Ⅱ. Does this pull request fix one issue?

#1623

Ⅲ. Why don't you add test cases (unit test/integration test)?

No new api.

Ⅳ. Describe how to verify it

  1. get newest server address list then start debug break point
  2. change server address list
  3. cancel break point, then add change listener
  4. receive change event,refresh address list

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #1629 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1629      +/-   ##
=============================================
- Coverage      47.19%   47.14%   -0.06%     
  Complexity      1778     1778              
=============================================
  Files            362      362              
  Lines          13227    13237      +10     
  Branches        1640     1641       +1     
=============================================
- Hits            6243     6240       -3     
- Misses          6307     6319      +12     
- Partials         677      678       +1
Impacted Files Coverage Δ Complexity Δ
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 11.36% <0%> (-0.94%) 3 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cd83b...826ec76. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!LGTM.

@xingfudeshi
Copy link
Member

@BeiKeJieDeLiuLangMao You need to re-push these commits.

@xingfudeshi
Copy link
Member

Because you've just associated your github account with email.

@slievrly slievrly changed the title Fix issue: address list change events leak. #1605 bugfix: address list change events leak. #1605 Sep 18, 2019
@slievrly slievrly changed the title bugfix: address list change events leak. #1605 bugfix: address list change events leak Sep 18, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ff90eb3 into apache:develop Sep 18, 2019
@BeiKeJieDeLiuLangMao BeiKeJieDeLiuLangMao deleted the fix-issue-1623 branch September 18, 2019 03:01
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants