Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: branch transaction repeated reporting false #1633

Merged
merged 6 commits into from
Sep 17, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Sep 10, 2019

Ⅰ. Describe what this PR did

Downstream processed branch status reporting, and only needs to be rollbacked local transaction when LOCK_RETRY_POLICY_BRANCH_ROLLBACK_ON_CONFLICT is false

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei closed this Sep 10, 2019
@zjinlei zjinlei reopened this Sep 10, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #1633 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1633      +/-   ##
=============================================
- Coverage      47.39%   47.38%   -0.02%     
- Complexity      1777     1778       +1     
=============================================
  Files            362      362              
  Lines          13151    13153       +2     
  Branches        1626     1627       +1     
=============================================
- Hits            6233     6232       -1     
- Misses          6245     6247       +2     
- Partials         673      674       +1
Impacted Files Coverage Δ Complexity Δ
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 73.52% <100%> (+1.65%) 7 <0> (+1) ⬆️
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520c5ca...bf353cf. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s my fault, LGTM.

@xingfudeshi xingfudeshi self-requested a review September 17, 2019 08:28
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
UT is passed.

@xingfudeshi xingfudeshi merged commit ebcae5f into apache:develop Sep 17, 2019
@zjinlei zjinlei deleted the optimize/duplicateReport branch September 17, 2019 11:50
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants