Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: could not serialize and deserialize in java.sql.Blob, java.sql.Clob #1643

Merged
merged 13 commits into from
Sep 17, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Fix could not serialize and deserialize in java.sql.Blob, java.sql.Clob

Ⅱ. Does this pull request fix one issue?

#1636

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1643 into develop will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1643      +/-   ##
=============================================
+ Coverage      47.23%   47.26%   +0.02%     
- Complexity      1764     1765       +1     
=============================================
  Files            359      359              
  Lines          13005    13055      +50     
  Branches        1620     1626       +6     
=============================================
+ Hits            6143     6170      +27     
- Misses          6194     6215      +21     
- Partials         668      670       +2
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/sql/struct/TableRecords.java 64.28% <10%> (-9.49%) 13 <0> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 77.77% <12.5%> (-5.4%) 21 <0> (ø)
...m/datasource/undo/parser/JacksonUndoLogParser.java 67.94% <70.58%> (+2.03%) 4 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+0.34%) 19% <0%> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.9% <0%> (+0.9%) 27% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3b98d...3e8e030. Read the comment docs.

@l81893521
Copy link
Contributor Author

can not rollback

@l81893521
Copy link
Contributor Author

fix can not roll back

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mysql blob
CREATE TABLE blob_tbl (
id int(11) NOT NULL,
name blob NOT NULL,
PRIMARY KEY (id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

insert into blob_tbl(id,name) values(1,'123');

update blob_tbl set name='456' where id=1;

try to rollback;

check result OK.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORACLE:

CREATE TABLE BLOB_TBL (
id NUMBER(20,0) NOT NULL,
name blob NOT NULL,
name1 clob NOT NULL,
PRIMARY KEY (id)
);

insert into blob_tbl(id,name,name1) values(1,'123','123');

update blob_tbl set name='456',name1='456' where id=1;
try to rollback
image

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check oracle result is OK.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 62e7580 into apache:develop Sep 17, 2019
@l81893521 l81893521 deleted the fix_serialize_blob_clob branch September 17, 2019 11:27
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants