-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: could not serialize and deserialize in java.sql.Blob, java.sql.Clob #1643
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1643 +/- ##
=============================================
+ Coverage 47.23% 47.26% +0.02%
- Complexity 1764 1765 +1
=============================================
Files 359 359
Lines 13005 13055 +50
Branches 1620 1626 +6
=============================================
+ Hits 6143 6170 +27
- Misses 6194 6215 +21
- Partials 668 670 +2
Continue to review full report at Codecov.
|
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/JacksonUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/parser/JacksonUndoLogParser.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableRecords.java
Outdated
Show resolved
Hide resolved
can not rollback |
fix can not roll back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mysql blob
CREATE TABLE blob_tbl
(
id
int(11) NOT NULL,
name
blob NOT NULL,
PRIMARY KEY (id
)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
insert into blob_tbl(id,name) values(1,'123');
update blob_tbl set name='456' where id=1;
try to rollback;
check result OK.
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableRecords.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…serialize_blob_clob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check oracle result is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Fix could not serialize and deserialize in java.sql.Blob, java.sql.Clob
Ⅱ. Does this pull request fix one issue?
#1636
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews