-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: selectForUpdate lockQuery exception in file mode #1646
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1646 +/- ##
=============================================
- Coverage 47.21% 47.17% -0.04%
Complexity 1778 1778
=============================================
Files 362 362
Lines 13225 13227 +2
Branches 1641 1640 -1
=============================================
- Hits 6244 6240 -4
- Misses 6306 6309 +3
- Partials 675 678 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please correct the message by the way.
branchSession can't be null for memory/file locker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
你好大佬 这个bug我提的 我想深入的研究一下 可以给我发一份seata的时序图和详细的流程图吗。非常感谢 qq邮箱965162704@qq.com 或者 阿里邮箱ming.yifei@xyb2b.com |
You may find these images on the site seata.io. |
看到了 谢谢 |
Ⅰ. Describe what this PR did
file mode rm selectForUpdate lockQuery exception
Ⅱ. Does this pull request fix one issue?
fixes #1586
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews