Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: selectForUpdate lockQuery exception in file mode #1646

Merged
merged 5 commits into from
Sep 17, 2019
Merged

bugfix: selectForUpdate lockQuery exception in file mode #1646

merged 5 commits into from
Sep 17, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Sep 12, 2019

Ⅰ. Describe what this PR did

file mode rm selectForUpdate lockQuery exception

Ⅱ. Does this pull request fix one issue?

fixes #1586

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #1646 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1646      +/-   ##
=============================================
- Coverage      47.21%   47.17%   -0.04%     
  Complexity      1778     1778              
=============================================
  Files            362      362              
  Lines          13225    13227       +2     
  Branches        1641     1640       -1     
=============================================
- Hits            6244     6240       -4     
- Misses          6306     6309       +3     
- Partials         675      678       +3
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/server/lock/LockerFactory.java 45% <ø> (+4.09%) 3 <0> (ø) ⬇️
.../java/io/seata/server/lock/DefaultLockManager.java 47.91% <0%> (-4.36%) 12 <2> (ø)
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.4%) 19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1617187...05fca85. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi
Copy link
Member

Please correct the message by the way.
In LockerFactory

else if (StoreMode.FILE.name().equalsIgnoreCase(storeMode)) {
            if (branchSession == null) {
                throw new IllegalArgumentException("branchSession can be null for memory/file locker.");
            }

branchSession can't be null for memory/file locker.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: file mode rm selectForUpdate lockQuery exception bugfix: selectForUpdate lockQuery exception in file mode Sep 17, 2019
@slievrly slievrly merged commit 98cd83b into apache:develop Sep 17, 2019
@GhostBoyBoy
Copy link

GhostBoyBoy commented Sep 18, 2019

LGTM

LGTM

你好大佬 这个bug我提的 我想深入的研究一下 可以给我发一份seata的时序图和详细的流程图吗。非常感谢 qq邮箱965162704@qq.com 或者 阿里邮箱ming.yifei@xyb2b.com

@xingfudeshi
Copy link
Member

You may find these images on the site seata.io.

@GhostBoyBoy
Copy link

You may find these images on the site seata.io.

看到了 谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

存储模型使用文件,服务器端分支事务会话为空 seata0.71 jdk1.8
6 participants