Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: transaction_name too long #1648

Merged
merged 1 commit into from
Sep 12, 2019
Merged

bugfix: transaction_name too long #1648

merged 1 commit into from
Sep 12, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Sep 12, 2019

Ⅰ. Describe what this PR did

transaction_name too long cause insert failed.

Ⅱ. Does this pull request fix one issue?

fixes #1635

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #1648 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1648   +/-   ##
==========================================
  Coverage      47.23%   47.23%           
  Complexity      1764     1764           
==========================================
  Files            359      359           
  Lines          12999    12999           
  Branches        1617     1617           
==========================================
  Hits            6140     6140           
  Misses          6193     6193           
  Partials         666      666

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186baf3...f5b2d23. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 1f15891 into apache:develop Sep 12, 2019
@jsbxyyx jsbxyyx deleted the fix_1635 branch September 12, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data too long for column 'transaction_name'
6 participants