-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: fix wrong usage of Slf4j #1654
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1654 +/- ##
=============================================
+ Coverage 47.37% 47.39% +0.02%
Complexity 1777 1777
=============================================
Files 362 362
Lines 13151 13151
Branches 1626 1626
=============================================
+ Hits 6230 6233 +3
+ Misses 6247 6245 -2
+ Partials 674 673 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use import xxx.*
core/src/main/java/io/seata/core/rpc/DefaultServerMessageListenerImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/DefaultServerMessageListenerImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/DefaultServerMessageListenerImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/RmMessageListener.java
Outdated
Show resolved
Hide resolved
@lightClouds917 @xingfudeshi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There are several places that are not correct for the use of Slf4j.
They log error log like this:
It will print log like below, missing the log message:
I correct it like this:
So, it will print the expected log content: