feature: support spring cloud config #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1656 +/- ##
=============================================
+ Coverage 48.18% 48.21% +0.03%
Complexity 1841 1841
=============================================
Files 365 365
Lines 13279 13279
Branches 1639 1639
=============================================
+ Hits 6398 6402 +4
+ Misses 6220 6218 -2
+ Partials 661 659 -2
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
Sep 18, 2019
...-config-spring-cloud/src/main/java/io/seata/config/springcloud/SpringCloudConfiguration.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Sep 18, 2019
...-config-spring-cloud/src/main/java/io/seata/config/springcloud/SpringCloudConfiguration.java
Show resolved
Hide resolved
xingfudeshi
reviewed
Sep 18, 2019
...a-config-spring-cloud/src/main/java/io/seata/config/springcloud/EnableSeataSpringConfig.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Sep 18, 2019
add private constructor of SpringCloudConfiguration
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support spring cloud config #1078
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
set config type with value SpringCloudConfig in registry.conf then add mvn dependency seata-config-spring-cloud and add @EnableSeataSpringConfig
Ⅴ. Special notes for reviews