-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: get table meta fail when table name was keyword #1663
bugfix: get table meta fail when table name was keyword #1663
Conversation
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1663 +/- ##
=============================================
- Coverage 47.36% 47.35% -0.02%
+ Complexity 1779 1778 -1
=============================================
Files 362 362
Lines 13167 13168 +1
Branches 1633 1633
=============================================
- Hits 6237 6236 -1
- Misses 6255 6256 +1
- Partials 675 676 +1
Continue to review full report at Codecov.
|
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Fix get table meta fail when table name was keyword
Ⅱ. Does this pull request fix one issue?
#1662
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews