Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get table meta fail when table name was keyword #1663

Merged
merged 7 commits into from
Sep 17, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Fix get table meta fail when table name was keyword

Ⅱ. Does this pull request fix one issue?

#1662

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #1663 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1663      +/-   ##
=============================================
- Coverage      47.36%   47.35%   -0.02%     
+ Complexity      1779     1778       -1     
=============================================
  Files            362      362              
  Lines          13167    13168       +1     
  Branches        1633     1633              
=============================================
- Hits            6237     6236       -1     
- Misses          6255     6256       +1     
- Partials         675      676       +1
Impacted Files Coverage Δ Complexity Δ
...seata/rm/datasource/sql/struct/TableMetaCache.java 55.97% <100%> (+0.27%) 14 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (-0.91%) 26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779fdf9...c0107e6. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review September 17, 2019 08:51
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit 70c7c54 into apache:develop Sep 17, 2019
@l81893521 l81893521 deleted the table_meta_table_name_in_keyword branch September 17, 2019 11:24
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants