Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: restore autocommit #1666

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Sep 17, 2019

Ⅰ. Describe what this PR did

apache/incubator-seata-samples#226
After the connection is used, restore the commit status of the initial connection.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #1666 into develop will increase coverage by 0.14%.
The diff coverage is 25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1666      +/-   ##
=============================================
+ Coverage      47.22%   47.36%   +0.14%     
+ Complexity      1778     1777       -1     
=============================================
  Files            362      362              
  Lines          13127    13165      +38     
  Branches        1590     1632      +42     
=============================================
+ Hits            6199     6236      +37     
- Misses          6242     6254      +12     
+ Partials         686      675      -11
Impacted Files Coverage Δ Complexity Δ
.../rm/datasource/undo/mysql/MySQLUndoLogManager.java 2.96% <0%> (-0.1%) 2 <0> (ø)
...m/datasource/undo/oracle/OracleUndoLogManager.java 3.05% <0%> (-0.1%) 2 <0> (ø)
...a/io/seata/core/store/db/LockStoreDataBaseDAO.java 52.9% <50%> (-0.11%) 20 <1> (ø)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 71.87% <0%> (-1.66%) 6% <0%> (-1%)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.61%) 67% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.95% <0%> (-0.21%) 3% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 22.88% <0%> (-0.2%) 10% <0%> (ø)
...tobuf/convertor/BranchCommitResponseConvertor.java 97.43% <0%> (+0.06%) 3% <0%> (ø) ⬇️
...in/java/io/seata/server/session/BranchSession.java 78.19% <0%> (+0.07%) 41% <0%> (ø) ⬇️
...buf/convertor/BranchRollbackResponseConvertor.java 97.36% <0%> (+0.07%) 3% <0%> (ø) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcae5f...0732b0c. Read the comment docs.

@xingfudeshi xingfudeshi self-requested a review September 17, 2019 08:48
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 779fdf9 into apache:develop Sep 17, 2019
@zjinlei zjinlei deleted the bugfix/restore-autocommit branch October 10, 2019 01:41
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants