-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: restore autocommit #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #1666 +/- ##
=============================================
+ Coverage 47.22% 47.36% +0.14%
+ Complexity 1778 1777 -1
=============================================
Files 362 362
Lines 13127 13165 +38
Branches 1590 1632 +42
=============================================
+ Hits 6199 6236 +37
- Misses 6242 6254 +12
+ Partials 686 675 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
apache/incubator-seata-samples#226
After the connection is used, restore the commit status of the initial connection.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews