Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: sql statement escape symbol #1668

Merged
merged 71 commits into from
Dec 16, 2019
Merged

bugfix: sql statement escape symbol #1668

merged 71 commits into from
Dec 16, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Sep 18, 2019 •
edited

Ⅰ. Describe what this PR did

bugfix:

  1. insert column has escape symbol
  2. insert afterImage primary key is keyword.

Ⅱ. Does this pull request fix one issue?

fixes #1665 #1667 #1655

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 18, 2019 •
edited

Codecov Report

Merging #1668 into develop will increase coverage by 0.39%.
The diff coverage is 74.73%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1668      +/-   ##
=============================================
+ Coverage      54.95%   55.34%   +0.39%     
- Complexity      2472     2504      +32     
=============================================
  Files            444      445       +1     
  Lines          14809    14838      +29     
  Branches        1749     1749              
=============================================
+ Hits            8138     8212      +74     
+ Misses          5921     5862      -59     
- Partials         750      764      +14
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/rm/datasource/sql/struct/IndexMeta.java 100% <ø> (ø) 32 <0> (-1) ⬇️
...o/seata/rm/datasource/AbstractConnectionProxy.java 17.2% <0%> (ø) 8 <0> (ø) ⬇️
.../io/seata/rm/datasource/sql/struct/ColumnMeta.java 98.31% <0%> (-1.69%) 59 <0> (ø)
...va/io/seata/rm/datasource/exec/InsertExecutor.java 65.89% <10%> (-3.34%) 40 <0> (-1)
...tasource/undo/oracle/OracleUndoInsertExecutor.java 69.23% <100%> (+69.23%) 3 <0> (+3) ⬆️
...tasource/undo/oracle/OracleUndoDeleteExecutor.java 88.23% <100%> (+88.23%) 5 <2> (+5) ⬆️
...seata/rm/datasource/undo/AbstractUndoExecutor.java 76.85% <100%> (+0.43%) 22 <1> (+1) ⬆️
...tasource/undo/oracle/OracleUndoUpdateExecutor.java 86.66% <100%> (+86.66%) 4 <1> (+4) ⬆️
...a/io/seata/rm/datasource/sql/struct/TableMeta.java 96.61% <100%> (-0.22%) 29 <2> (-1)
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 92.3% <66.66%> (ø) 11 <0> (ø) ⬇️
... and 7 more

xingfudeshi
xingfudeshi approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTs are passed.LGTM.

@jsbxyyx jsbxyyx changed the title bugfix insert column have escape symbol bugfix insert column has escape symbol Sep 25, 2019
@jsbxyyx jsbxyyx changed the title bugfix insert column has escape symbol bugfix insert column has escape symbol and oracle batch insert Sep 25, 2019
@jsbxyyx jsbxyyx changed the title bugfix insert column has escape symbol and oracle batch insert bugfix insert column has escape symbol Oct 8, 2019
@jsbxyyx jsbxyyx changed the title bugfix: insert column has escape symbol bugfix: insert column and table name has escape symbol Oct 21, 2019
@zjinlei zjinlei added this to the 1.0 milestone Oct 23, 2019
zjinlei
zjinlei reviewed Dec 15, 2019
View reviewed changes
common/src/test/java/io/seata/common/exception/FrameworkExceptionTest.java Outdated Show resolved Hide resolved
...-seata/src/main/java/io/seata/codec/seata/protocol/transaction/GlobalReportRequestCodec.java Outdated Show resolved Hide resolved
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java Outdated Show resolved Hide resolved
core/src/main/java/io/seata/core/rpc/netty/NettyPoolableFactory.java Outdated Show resolved Hide resolved
core/src/main/java/io/seata/core/rpc/netty/RmMessageListener.java Outdated Show resolved Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java Outdated Show resolved Hide resolved
...src/main/java/io/seata/integration/grpc/interceptor/server/ServerTransactionInterceptor.java Outdated Show resolved Hide resolved
integration/motan/src/main/java/io/seata/integration/motan/MotanTransactionFilter.java Outdated Show resolved Hide resolved
...n/sofa-rpc/src/main/java/io/seata/integration/sofa/rpc/TransactionContextConsumerFilter.java Outdated Show resolved Hide resolved
...n/sofa-rpc/src/main/java/io/seata/integration/sofa/rpc/TransactionContextProviderFilter.java Outdated Show resolved Hide resolved
@jsbxyyx jsbxyyx changed the title bugfix: insert column and table name has escape symbol bugfix: sql statement escape symbol Dec 16, 2019
zjinlei
zjinlei approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit d8bfdfb into apache:develop Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@zjinlei zjinlei zjinlei approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

table use keyword as primary key field cause InsertExecutor afterImage error
5 participants
@jsbxyyx @codecov-io @slievrly @zjinlei @xingfudeshi