-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:pk too long in lock table on db mode and optimize error log. #1685
bugfix:pk too long in lock table on db mode and optimize error log. #1685
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1685 +/- ##
============================================
- Coverage 47.15% 47% -0.15%
+ Complexity 1785 1784 -1
============================================
Files 364 365 +1
Lines 13251 13299 +48
Branches 1642 1642
============================================
+ Hits 6248 6251 +3
- Misses 6324 6370 +46
+ Partials 679 678 -1
Continue to review full report at Codecov.
|
server/src/main/java/io/seata/server/lock/db/DataBaseLocker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/AbstractTCInboundHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
core/src/main/java/io/seata/core/exception/TransactionExceptionCode.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
pk too long in lock table on db mode and optimize error log.
Ⅱ. Does this pull request fix one issue?
fixes #1679
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews