Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:pk too long in lock table on db mode and optimize error log. #1685

Merged
merged 6 commits into from
Sep 24, 2019
Merged

bugfix:pk too long in lock table on db mode and optimize error log. #1685

merged 6 commits into from
Sep 24, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Sep 20, 2019

Ⅰ. Describe what this PR did

pk too long in lock table on db mode and optimize error log.

Ⅱ. Does this pull request fix one issue?

fixes #1679

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #1685 into develop will decrease coverage by 0.14%.
The diff coverage is 3.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1685      +/-   ##
============================================
- Coverage      47.15%     47%   -0.15%     
+ Complexity      1785    1784       -1     
============================================
  Files            364     365       +1     
  Lines          13251   13299      +48     
  Branches        1642    1642              
============================================
+ Hits            6248    6251       +3     
- Misses          6324    6370      +46     
+ Partials         679     678       -1
Impacted Files Coverage Δ Complexity Δ
...n/java/io/seata/server/lock/db/DataBaseLocker.java 24.13% <0%> (-6.3%) 5 <0> (ø)
...io/seata/common/exception/DataAccessException.java 0% <0%> (ø) 0 <0> (?)
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 59.06% <0%> (ø) 21 <0> (ø) ⬇️
...a/io/seata/core/store/db/LockStoreDataBaseDAO.java 52.9% <0%> (ø) 20 <0> (ø) ⬇️
...java/io/seata/server/AbstractTCInboundHandler.java 1.29% <0%> (-0.79%) 1 <0> (ø)
...seata/core/exception/TransactionExceptionCode.java 82.75% <100%> (+0.61%) 2 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (-0.91%) 26% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df84fdb...93c12ae. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix pk too long in lock table on db mode and optimize error log. bugfix:pk too long in lock table on db mode and optimize error log. Sep 24, 2019
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 1b3b9ab into apache:develop Sep 24, 2019
@jsbxyyx jsbxyyx deleted the fix_server_pk_size_and_lock_log branch September 24, 2019 09:52
@wangliang181230 wangliang181230 added this to the 0.9.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seata client error Global lock wait timout
6 participants