Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:support new parameter option "-e" used for setting name of configuration. #1689

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Sep 21, 2019

Ⅰ. Describe what this PR did

As described in issue #1683,So i added a new parameter option "-e" to fix it.
And this is only available on the server side,for the client side,you can still use JVM parameter to set
the name of multi-configuration isolation directly.

Usage: sh seata-server.sh(for linux and mac) or cmd seata-server.bat(for 
      windows) [options]
  Options:
    --host, -h
      The ip to register to registry center.
    --port, -p
      The port to listen.
      Default: 8091
    --storeMode, -m
      log store mode : file、db
    --serverNode, -n
      server node id, such as 1, 2, 3. default is 1
      Default: 1
    --seataEnv, -e
      The name used for multi-configuration isolation.
    --help

Ⅱ. Does this pull request fix one issue?

fixes #1683

Ⅲ. Why don't you add test cases (unit test/integration test)?

UT provided,i've tested it.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

After this PR merged,i will update wiki as well.

@codecov-io
Copy link

codecov-io commented Sep 21, 2019

Codecov Report

Merging #1689 into develop will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1689      +/-   ##
============================================
+ Coverage      46.99%     47%   +<.01%     
- Complexity      1785    1787       +2     
============================================
  Files            365     365              
  Lines          13299   13301       +2     
  Branches        1642    1644       +2     
============================================
+ Hits            6250    6252       +2     
  Misses          6371    6371              
  Partials         678     678
Impacted Files Coverage Δ Complexity Δ
...eata/core/rpc/netty/AbstractRpcRemotingServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
server/src/main/java/io/seata/server/Server.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...src/main/java/io/seata/server/ParameterParser.java 56.66% <100%> (+3.09%) 8 <1> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3b9ab...8dcac46. Read the comment docs.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed. LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cause "option error" when pass -D parameter to seata-server.sh
5 participants