Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix can not access a member of DruidDataSourceWrapper #1691

Merged
merged 9 commits into from
Oct 8, 2019
Merged

bugfix:fix can not access a member of DruidDataSourceWrapper #1691

merged 9 commits into from
Oct 8, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

fix can not access a member of DruidDataSourceWrapper with modifiers "public"

Ⅱ. Does this pull request fix one issue?

fixes #1690

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration test.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 21, 2019

Codecov Report

Merging #1691 into develop will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1691      +/-   ##
=============================================
- Coverage      48.19%   48.06%   -0.13%     
  Complexity      1841     1841              
=============================================
  Files            365      365              
  Lines          13276    13279       +3     
  Branches        1639     1612      -27     
=============================================
- Hits            6398     6383      -15     
- Misses          6217     6220       +3     
- Partials         661      676      +15
Impacted Files Coverage Δ Complexity Δ
...ta/spring/annotation/GlobalTransactionScanner.java 50% <0%> (-1.41%) 17 <0> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 88% <0%> (-8%) 3% <0%> (ø)
...buf/convertor/GlobalLockQueryRequestConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 91.66% <0%> (-4.17%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 92.59% <0%> (-3.71%) 3% <0%> (ø)
...otobuf/convertor/BranchCommitRequestConvertor.java 96.42% <0%> (-3.58%) 3% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea1405...8709a2d. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi requested review from lovepoem and removed request for l81893521 and zjinlei September 28, 2019 03:50
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobalTransactionScanner can not access a member of DruidDataSourceWrapper with modifiers "public"
6 participants