-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix can not access a member of DruidDataSourceWrapper #1691
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1691 +/- ##
=============================================
- Coverage 48.19% 48.06% -0.13%
Complexity 1841 1841
=============================================
Files 365 365
Lines 13276 13279 +3
Branches 1639 1612 -27
=============================================
- Hits 6398 6383 -15
- Misses 6217 6220 +3
- Partials 661 676 +15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix can not access a member of DruidDataSourceWrapper with modifiers "public"
Ⅱ. Does this pull request fix one issue?
fixes #1690
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration test.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews