Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove unused imports #1701

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

cmonkey
Copy link
Contributor

@cmonkey cmonkey commented Sep 24, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #1701 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1701      +/-   ##
=============================================
+ Coverage      47.15%   47.16%   +<.01%     
  Complexity      1784     1784              
=============================================
  Files            364      364              
  Lines          13251    13251              
  Branches        1642     1642              
=============================================
+ Hits            6249     6250       +1     
  Misses          6323     6323              
+ Partials         679      678       -1
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/discovery/registry/RegistryFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../rm/datasource/AbstractPreparedStatementProxy.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../main/java/io/seata/rm/datasource/AsyncWorker.java 16.43% <ø> (ø) 4 <0> (ø) ⬇️
...io/seata/rm/datasource/AbstractStatementProxy.java 15.25% <ø> (ø) 4 <0> (ø) ⬇️
...rm/datasource/sql/druid/MySQLDeleteRecognizer.java 74.19% <ø> (ø) 6 <0> (ø) ⬇️
...urce/sql/druid/MySQLSelectForUpdateRecognizer.java 68.18% <ø> (ø) 7 <0> (ø) ⬇️
...n/java/io/seata/rm/datasource/ConnectionProxy.java 22.88% <ø> (ø) 10 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+0.34%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ef58b...d303093. Read the comment docs.

@slievrly slievrly changed the title remove unused imports optimize: remove unused imports Sep 24, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review September 24, 2019 03:23
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit df84fdb into apache:develop Sep 24, 2019
@cmonkey cmonkey deleted the feature/remove-unused-imports branch September 24, 2019 03:28
@wangliang181230 wangliang181230 added this to the 0.9.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants