Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: correct LockManagerTest.concurrentUseAbilityTest assertion condition #1713

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

ggndnn
Copy link
Contributor

@ggndnn ggndnn commented Sep 26, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix #1694

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #1713 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1713      +/-   ##
=============================================
+ Coverage         47%   47.01%   +<.01%     
  Complexity      1786     1786              
=============================================
  Files            365      365              
  Lines          13301    13301              
  Branches        1644     1644              
=============================================
+ Hits            6252     6253       +1     
  Misses          6370     6370              
+ Partials         679      678       -1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+0.34%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b12f5...fbcb9f4. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultCoreForEventBusTest#concurrentUseAbilityTest may fail
5 participants