bugfix: fix can't refresh table meta data for oracle #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1720 +/- ##
=============================================
+ Coverage 46.99% 48.21% +1.21%
- Complexity 1787 1841 +54
=============================================
Files 365 365
Lines 13298 13276 -22
Branches 1644 1639 -5
=============================================
+ Hits 6250 6401 +151
+ Misses 6369 6215 -154
+ Partials 679 660 -19
Continue to review full report at Codecov.
|
… into can_not_refresh_table_meta_oracle
xingfudeshi
reviewed
Sep 29, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Sep 29, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCacheOracle.java
Outdated
Show resolved
Hide resolved
|
please remove TableMetaCache#resultSetMetaToSchema(java.sql.ResultSet rs2, AbstractConnectionProxy conn, String tableName) the method is never used. |
|
It is recommended to abstract the public methods of TableMetaCache and TableMetaCacheOracle to a base class BaseTableMetaCache. |
…ble_meta_oracle # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java
ok |
slievrly
changed the title
xingfudeshi
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix can not refresh table meta data for oracle
Ⅱ. Does this pull request fix one issue?
#1719 #1714
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews