optimize: simplify to make codes more readable #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ⅰ. Describe what this PR did Simplify to make codes more readable. Ⅱ. Does this pull request fix one issue? No. Ⅲ. Why don't you add test cases (unit test/integration test)? Ⅳ. Describe how to verify it Ⅴ. Special notes for reviews
Codecov Report
@@ Coverage Diff @@
## develop #1722 +/- ##
=============================================
- Coverage 47% 46.97% -0.04%
- Complexity 1786 1787 +1
=============================================
Files 365 365
Lines 13300 13298 -2
Branches 1644 1644
=============================================
- Hits 6252 6247 -5
- Misses 6369 6371 +2
- Partials 679 680 +1
Continue to review full report at Codecov.
|
Ⅰ. Describe what this PR did Delete the redundant condition. If the left argument is null, instanceof will return false anyway. Ⅱ. Does this pull request fix one issue? Ⅲ. Why don't you add test cases (unit test/integration test)? Ⅳ. Describe how to verify it Ⅴ. Special notes for reviews
tjnettech
changed the title
xingfudeshi
reviewed
Sep 29, 2019
codec/seata-codec-kryo/src/main/java/io/seata/codec/kryo/KryoCodec.java
Outdated
Show resolved
Hide resolved
Change the content of the message.
xingfudeshi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Simplify to make codes more readable.
Ⅱ. Does this pull request fix one issue?
No.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews