feature:add seata-spring-boot-starter #1742

xingfudeshi · 2019-10-10T15:06:41Z

Ⅰ. Describe what this PR did

Support spring-boot auto configuration of Seata.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration test with spring-boot 2.1.4.RELEASE and spring-boot 1.5.22.RELEASE

Ⅳ. Describe how to verify it

If your project uses spring-boot, just add the following dependency to the pom.

<dependency>
      <groupId>io.seata</groupId>
      <artifactId>seata-spring-boot-starter</artifactId>
      <version>{seata.version}</version>
</dependency>

In your application.yml

seata:
  application-id: test
  tx-service-group: my_test_tx_group

Or application.properties

seata.application-id=test
seata.tx-service-group=my_test_tx_group

Other configurations have default values.

Ⅴ. Special notes for reviews

codecov-io · 2019-10-10T15:16:56Z

Codecov Report

Merging #1742 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1742      +/-   ##
=============================================
+ Coverage      55.06%   55.08%   +0.02%     
  Complexity      2355     2355              
=============================================
  Files            421      421              
  Lines          14264    14264              
  Branches        1710     1710              
=============================================
+ Hits            7854     7858       +4     
+ Misses          5682     5680       -2     
+ Partials         728      726       -2

Impacted Files	Coverage Δ	Complexity Δ
...server/store/file/FileTransactionStoreManager.java	`60.19% <0%> (+1.31%)`	`29% <0%> (ø)`	⬇️

...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SpringProperties.java

...rter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SupportProperties.java

...in/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryEurekaProperties.java

…-boot-starter

...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryNacosProperties.java

...a-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java

...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java

seata-spring-boot-starter/pom.xml

This reverts commit 6ed3448

...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryRedisProperties.java

jsbxyyx · 2019-10-17T06:37:30Z

please check *Properties default value has constants. if has constants then use the constants.

jsbxyyx

Test pass. LGTM

xingfudeshi · 2019-10-17T07:12:34Z

please check *Properties default value has constants. if has constants then use the constants.

sure.i will check.

config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java

...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/ClientProperties.java

...rter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/ServiceProperties.java

...r/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/ConfigProperties.java

...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryEecd3Properties.java

This reverts commit efe00ea

seata-spring-boot-starter/pom.xml

zjinlei

LGTM

slievrly · 2019-10-28T03:26:23Z

pom.xml

@@ -44,6 +44,7 @@
        <module>tm</module>
        <module>metrics</module>
        <module>codec</module>
+        <module>seata-spring-boot-starter</module>


need with seata prefix？

slievrly · 2019-11-01T08:46:15Z

...ng-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataAutoConfiguration.java

+ */
+@ComponentScan(basePackages = "io.seata.spring.boot.autoconfigure.properties")
+@ConditionalOnProperty(prefix = StarterConstants.SEATA_PREFIX, name = "enabled", matchIfMissing = true)
+@ConditionalOnClass({DataSourceProxy.class})


if not contains AT mode.

slievrly · 2019-11-01T08:46:33Z

...ng-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataAutoConfiguration.java

+ * @date 2019/09/30
+ */
+@ComponentScan(basePackages = "io.seata.spring.boot.autoconfigure.properties")
+@ConditionalOnProperty(prefix = StarterConstants.SEATA_PREFIX, name = "enabled", matchIfMissing = true)


check seata.enable value.

xingfudeshi added 2 commits October 10, 2019 23:04

support spring-boot auto configuration

e1debce

Merge branch 'develop' into spring-boot-starter

7ff11ac

Merge branch 'develop' into spring-boot-starter

2889bf6

xingfudeshi added the type: feature Category issues or prs related to feature request. label Oct 10, 2019

Merge branch 'develop' into spring-boot-starter

10f3386

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SpringProperties.java Show resolved Hide resolved

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...arter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SpringProperties.java Outdated Show resolved Hide resolved

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...rter/src/main/java/io/seata/spring/boot/autoconfigure/properties/file/SupportProperties.java Outdated Show resolved Hide resolved

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...in/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryEurekaProperties.java Outdated Show resolved Hide resolved

xingfudeshi added 2 commits October 11, 2019 10:52

remove unused imports.

de28a7d

Merge remote-tracking branch 'origin/spring-boot-starter' into spring…

fbe225e

…-boot-starter

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryNacosProperties.java Outdated Show resolved Hide resolved

xingfudeshi added 2 commits October 11, 2019 11:20

add missing properties.

7f38d25

config missing properties for config&registry

58e57e7

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...a-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java Outdated Show resolved Hide resolved

unify the default port for eureka.

a0c7cb2

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java Outdated Show resolved Hide resolved

code format.

e740cbd

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

seata-spring-boot-starter/pom.xml Outdated Show resolved Hide resolved

xingfudeshi added 8 commits October 11, 2019 12:43

extends from parent.

6ed3448

set the capacity for HashMap

0a291e2

fix coverage

ff693bd

Revert "extends from parent."

7327b91

This reverts commit 6ed3448

fix coverage

7737ec4

fix coverage

f6bb843

use seata-all

1d3f187

degrades the version of spring-boot 1.5.22.RELEASE

2c22e2a

jsbxyyx reviewed Oct 11, 2019

View reviewed changes

...ain/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryRedisProperties.java Show resolved Hide resolved

Merge branch 'develop' into spring-boot-starter

a547036

Merge branch 'develop' into spring-boot-starter

4ca93bc

jsbxyyx approved these changes Oct 17, 2019

View reviewed changes

xingfudeshi added 4 commits October 18, 2019 13:12

Merge branch 'develop' into spring-boot-starter

70e421f

Merge branch 'develop' into spring-boot-starter

10a9c2d

Merge branch 'develop' into spring-boot-starter

c7a1e61

Merge branch 'develop' into spring-boot-starter

005d5a4

zjinlei reviewed Oct 21, 2019

View reviewed changes

zjinlei and others added 14 commits October 21, 2019 19:43

Merge branch 'develop' into spring-boot-starter

103bf8f

Merge branch 'develop' into spring-boot-starter

6db8366

Merge branch 'develop' into spring-boot-starter

7aa1c59

fix reviews and add missing configurations.

f030d19

Merge branch 'develop' into spring-boot-starter

5267c19

Merge branch 'develop' into spring-boot-starter

6953a6c

Merge branch 'develop' into spring-boot-starter

9461671

Merge branch 'develop' into spring-boot-starter

f7512ab

Merge branch 'develop' into spring-boot-starter

5e9cd84

update codecov.yml

efe00ea

Revert "update codecov.yml"

f0ba5b1

This reverts commit efe00ea

Merge branch 'develop' into spring-boot-starter

eccc6e2

Merge branch 'develop' into spring-boot-starter

f19de4e

Merge branch 'develop' into spring-boot-starter

eda2d62

zjinlei reviewed Oct 27, 2019

View reviewed changes

seata-spring-boot-starter/pom.xml Show resolved Hide resolved

Merge branch 'develop' into spring-boot-starter

59aad16

zjinlei approved these changes Oct 28, 2019

View reviewed changes

zjinlei merged commit 7c66b34 into apache:develop Oct 28, 2019

slievrly reviewed Oct 28, 2019

View reviewed changes

slievrly reviewed Nov 1, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature:add seata-spring-boot-starter #1742

feature:add seata-spring-boot-starter #1742

xingfudeshi commented Oct 10, 2019 •

edited

codecov-io commented Oct 10, 2019 •

edited

jsbxyyx commented Oct 17, 2019

jsbxyyx left a comment

xingfudeshi commented Oct 17, 2019

zjinlei left a comment

slievrly Oct 28, 2019

slievrly Nov 1, 2019

slievrly Nov 1, 2019

feature:add seata-spring-boot-starter #1742

feature:add seata-spring-boot-starter #1742

Conversation

xingfudeshi commented Oct 10, 2019 • edited

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io commented Oct 10, 2019 • edited

Codecov Report

jsbxyyx commented Oct 17, 2019

jsbxyyx left a comment

Choose a reason for hiding this comment

xingfudeshi commented Oct 17, 2019

zjinlei left a comment

Choose a reason for hiding this comment

slievrly Oct 28, 2019

Choose a reason for hiding this comment

slievrly Nov 1, 2019

Choose a reason for hiding this comment

slievrly Nov 1, 2019

Choose a reason for hiding this comment

xingfudeshi commented Oct 10, 2019 •

edited

codecov-io commented Oct 10, 2019 •

edited