Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixed problem when set useInformationSchema true and table name was keyword #1768

Merged
merged 8 commits into from
Oct 29, 2019

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Oct 14, 2019

Ⅰ. Describe what this PR did

fix can not get table meta when set useInformationSchema true and table name was keyword

Ⅱ. Does this pull request fix one issue?

#1765 #1767

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #1768 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1768      +/-   ##
=============================================
- Coverage      55.06%   55.06%   -0.01%     
+ Complexity      2355     2354       -1     
=============================================
  Files            421      421              
  Lines          14264    14266       +2     
  Branches        1710     1711       +1     
=============================================
  Hits            7855     7855              
  Misses          5682     5682              
- Partials         727      729       +2
Impacted Files Coverage Δ Complexity Δ
...tasource/sql/struct/cache/MysqlTableMetaCache.java 84.78% <0%> (-1.89%) 10 <0> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 49.59% <0%> (-0.41%) 27% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 59.86% <0%> (+0.65%) 30% <0%> (+1%) ⬆️

@xingfudeshi xingfudeshi changed the title bugfix: fixed get table meta failed when set useInformationSchema true and table name was keyword bugfix: fixed problem when set useInformationSchema true and table name was keyword Oct 15, 2019
@xingfudeshi xingfudeshi self-requested a review October 15, 2019 05:05
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei added this to the 1.0 milestone Oct 23, 2019
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 9dab05d into apache:develop Oct 29, 2019
@l81893521 l81893521 deleted the fix_get_table_meta_failed branch November 2, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants