Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: datasource manager branch rollback exception log #1775

Merged
merged 23 commits into from
Dec 18, 2019
Merged

optimize: datasource manager branch rollback exception log #1775

merged 23 commits into from
Dec 18, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Oct 15, 2019

Ⅰ. Describe what this PR did

update DataSourceManager.branchRollback exception log, convenience to troubleshoot problems.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@jsbxyyx jsbxyyx requested a review from zjinlei October 15, 2019 10:35
@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #1775 into develop will increase coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1775      +/-   ##
============================================
+ Coverage      55.18%   55.3%   +0.12%     
  Complexity      2521    2521              
============================================
  Files            445     446       +1     
  Lines          14882   14910      +28     
  Branches        1726    1765      +39     
============================================
+ Hits            8212    8246      +34     
- Misses          5883    5899      +16     
+ Partials         787     765      -22
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/io/seata/core/logger/StackTraceLogger.java 0% <0%> (ø) 0 <0> (?)
...java/io/seata/rm/datasource/DataSourceManager.java 26.98% <0%> (-0.44%) 7 <0> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.61%) 67% <0%> (ø)
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.5% <0%> (-0.33%) 2% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.83% <0%> (-0.22%) 12% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.64% <0%> (-0.2%) 3% <0%> (ø)
...ing/annotation/GlobalTransactionalInterceptor.java 10% <0%> (-0.15%) 2% <0%> (ø)
...in/java/io/seata/server/session/BranchSession.java 80.45% <0%> (-0.02%) 44% <0%> (ø)
... and 23 more

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Better than the current, but the probability of one in ten thousand is still too low.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a util class is needed to centrally control such scenarios, and the frequency is made into a configuration item.

private static final Configuration CONFIG = ConfigurationFactory.getInstance();

public static void info(Logger logger, Throwable cause, String format1, Object[] args1, String format2, Object[] args2) {
if (logger.isInfoEnabled()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args2=cause.getMessage?

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants