-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: xid header lowercase #1789
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1789 +/- ##
=============================================
+ Coverage 55.27% 55.28% +<.01%
- Complexity 2383 2386 +3
=============================================
Files 422 422
Lines 14282 14299 +17
Branches 1698 1702 +4
=============================================
+ Hits 7895 7905 +10
- Misses 5673 5678 +5
- Partials 714 716 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jsbxyyx Are there any other better options? If the consumer and provider do not use the same version after modification, the compatibility issue will be triggered. |
@slievrly For the old version, it seems that there is no good solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I researched the dubbo community and confirmed whether it is a bug. I think I need to be compatible with the previous version. I think I can make two judgments in the filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are other rpc frameworks unaffected?
fix done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1728
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews