Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: statemachine def can't store to db and provide query the state logs #1810

Merged
merged 56 commits into from
Nov 1, 2019
Merged

bugfix: statemachine def can't store to db and provide query the state logs #1810

merged 56 commits into from
Nov 1, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Oct 24, 2019 •
edited

Ⅰ. Describe what this PR did

Fix statemachine definition cannot store to db.
Provide API StateLogRepository for the query of state logs such as StateMachineInstances and StateInstances.

Ⅱ. Does this pull request fix one issue?

#1808
#1809

lorne.cl and others added 30 commits September 3, 2019 16:17
saga implement
d3c4cbe
saga implement
982cbd7
implement getStateMachineInstanceByBusinessKey
e2fe7e7
support table prefix
b7c891e
support transactions externally managed
8085000
state log store support transaction PropagationBehavior and Isolation…
2c4e3e0 
…Level
state log store support transaction PropagationBehavior and Isolation…
fd64918 
…Level
support mult tenants
e4c39ad
statelang json Status node expression as key, status as values
2a1964d
StateLogStore.getStateMachineInstanceByBusinessKey add parameter tena…
ad5bf43 
…ntId
schema sql script to lowercase
651ceca
change state type name "CompensationStart" to "CompensationTrigger"
b4d4966
improve DirectEventBus avoid stackoverflow
bf9d2f5
merge from upstream/develop
7638b6d
fix merge conflict
b5296f6
@long187
Merge branch 'develop' into develop
bffd21c
@long187
Merge branch 'develop' into develop
c9491de
remove mybatis,gson,commons dependencies
8a10c17
Merge branch 'develop' of https://github.com/long187/seata into develop
6c7bea4
merge from upstream
218b616
update saga test to junit5 and move to test project
597ec8a
Merge remote-tracking branch 'upstream/develop' into develop
a28bad9
@slievrly
Merge branch 'develop' into develop
7dd0791
support db2/oracle create schema scripts
a9ee505
Merge branch 'develop' of https://github.com/long187/seata into develop
a6fab5c
Merge remote-tracking branch 'upstream/develop' into develop
e3ed43b
fix mysql create table scripts
0a81952
Merge remote-tracking branch 'upstream/develop' into develop
5359e20
@long187
Merge branch 'develop' into develop
9bde6f6
fix code review optimization suggestions
fe1d071
lorne.cl and others added 16 commits October 8, 2019 21:20
Merge remote-tracking branch 'upstream/develop' into develop
cc94376
get dbType from datasoruce; if statemechine inst not exists, stop retry
423cd77
Merge remote-tracking branch 'upstream/develop' into develop
740abba
@l81893521
Merge branch 'develop' into develop
3ac4548
improve SpringBeanServiceInvoker.toJavaObject method, skip serialize …
129141e 
…when paramType isAssignableFrom value.getClass()
Merge branch 'develop' of https://github.com/long187/seata into develop
0b8408c
improve SpringBeanServiceInvoker.toJavaObject method, skip serialize …
549d85d 
…when paramType isAssignableFrom value.getClass()
merge from upstream
9cefd2d
merge from upstream
cd1af4c
Merge remote-tracking branch 'upstream/develop' into develop
806a1fc
@long187
Merge branch 'develop' into develop
a66721e
@slievrly
Merge branch 'develop' into develop
280bec8
Merge remote-tracking branch 'upstream/develop' into develop
6720c2d
release 0.9.0
c558cc8
@long187
merge from upstream
99855ba
@long187
fix statemachine def cannot store to db, provide StateLogRepository f…
ed6e559 
…or the query of State logs. apache#1808 apache#1809
@long187 long187 changed the title fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs Saga: fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs Oct 24, 2019
@codecov-io
Copy link

codecov-io commented Oct 24, 2019 •
edited

Codecov Report

Merging #1810 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1810   +/-   ##
==========================================
  Coverage      55.06%   55.06%           
+ Complexity      2355     2354    -1     
==========================================
  Files            421      421           
  Lines          14264    14264           
  Branches        1710     1710           
==========================================
  Hits            7855     7855           
+ Misses          5682     5680    -2     
- Partials         727      729    +2
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 49.59% <0%> (-0.41%) 28% <0%> (ø)
...server/store/file/FileTransactionStoreManager.java 59.86% <0%> (+0.65%) 29% <0%> (ø) ⬇️

@slievrly
Copy link
Member

brief commit log

@long187 long187 changed the title Saga: fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs Saga: fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs, Fix StateInstance log cannot record output parameters Oct 25, 2019
@zjinlei
Copy link
Contributor

zjinlei commented Oct 27, 2019

please resolve conflicts

@zjinlei zjinlei added this to the 1.0 milestone Oct 28, 2019
@long187 long187 changed the title Saga: fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs, Fix StateInstance log cannot record output parameters Saga: fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs Oct 29, 2019
@slievrly slievrly changed the title Saga: fix statemachine def cannot store to db, provide StateLogRepository for the query of state logs bugfix: statemachine def can't store to db and provide query the state logs Oct 31, 2019
slievrly
slievrly approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangthen
zhangthen approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit c772c7d into apache:develop Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@zhangthen zhangthen zhangthen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@long187 @codecov-io @slievrly @zjinlei @zhangthen @l81893521