-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: TCC support cross-service #1813
bugfix: TCC support cross-service #1813
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1813 +/- ##
=============================================
- Coverage 55.29% 55.26% -0.04%
- Complexity 2382 2383 +1
=============================================
Files 423 423
Lines 14278 14299 +21
Branches 1696 1700 +4
=============================================
+ Hits 7895 7902 +7
- Misses 5671 5685 +14
Partials 712 712
|
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/tcc/TccActionInterceptor.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/tcc/TccActionInterceptor.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Dubbo transaction ID cannot be passed in TCC transaction
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Use the Dubbo service and test the scenario as transaction - > Service 1 - > service 2
Ⅴ. Special notes for reviews