Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: TCC support cross-service #1813

Merged
merged 26 commits into from
Nov 12, 2019

Conversation

zhongfuhua
Copy link
Contributor

Ⅰ. Describe what this PR did

Dubbo transaction ID cannot be passed in TCC transaction

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Use the Dubbo service and test the scenario as transaction - > Service 1 - > service 2

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #1813 into develop will decrease coverage by 0.03%.
The diff coverage is 25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1813      +/-   ##
=============================================
- Coverage      55.29%   55.26%   -0.04%     
- Complexity      2382     2383       +1     
=============================================
  Files            423      423              
  Lines          14278    14299      +21     
  Branches        1696     1700       +4     
=============================================
+ Hits            7895     7902       +7     
- Misses          5671     5685      +14     
  Partials         712      712
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.5% <0%> (-0.66%) 2 <0> (ø)
...c/main/java/io/seata/core/context/RootContext.java 37.77% <28.57%> (-12.23%) 9 <2> (+1)
...server/store/file/FileTransactionStoreManager.java 57.91% <0%> (+0.94%) 29% <0%> (ø) ⬇️

@zjinlei zjinlei changed the base branch from 0.8.1 to develop October 24, 2019 10:25
@zjinlei zjinlei added this to the 1.0 milestone Oct 24, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title Dubbo transaction ID cannot be passed in TCC transaction bugfix: tcc cross-service pass xid Oct 28, 2019
@zjinlei zjinlei changed the title bugfix: tcc cross-service pass xid bugfix: TCC support cross-service pass xid Oct 28, 2019
@zjinlei zjinlei changed the title bugfix: TCC support cross-service pass xid bugfix: TCC support cross-service Oct 28, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit ba22294 into apache:develop Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants